On Tue, Aug 05, 2008 at 04:35:51PM +0300, Tony Lindgren wrote: > * Felipe Balbi <me@xxxxxxxxxxxxxxx> [080723 10:32]: > > > > > > On Wed, 23 Jul 2008 10:16:27 +0530, "Madhusudhan Chikkature" > > <madhu.cr@xxxxxx> wrote: > > > Hi Felipe, > > > > > >> Tony, weird that we still have these prototypes in these headers. > > >> Could be some merging conflict ? > > > Yes. I see that these prototypes are still present in the board3430 and > > > board2430 header files in the omap tree. > > > > > >> Anyways, please apply the attached patch. We're using > > >> usb_musb_init() and usb_ehci_init() now. > > > You mean I should apply the attached patch you sent for local use, right? > > > And I guess I dont need to resend this perticular BCI patch, am I > > correct? > > > > No :-) > > > > that was to Tony. Just replied to your mail so it's easy to see why we need > > that patch :-) > > Pushing these today. Do you have a patch for moving the extern > prototypes into the twl header? I was talking about these: From: Felipe Balbi <felipe.balbi@xxxxxxxxx> arch: omap: get rid of usb_init() protytpes we now use usb_musb_init() and usb_ehci_init() functions Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> --- diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h index fde6915..83d0eec 100644 --- a/include/asm-arm/arch-omap/board-2430sdp.h +++ b/include/asm-arm/arch-omap/board-2430sdp.h @@ -36,6 +36,5 @@ /* Function prototypes */ extern void sdp2430_flash_init(void); -extern void sdp2430_usb_init(void); #endif /* __ASM_ARCH_OMAP_2430SDP_H */ diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h index d583008..85f769e 100644 --- a/include/asm-arm/arch-omap/board-3430sdp.h +++ b/include/asm-arm/arch-omap/board-3430sdp.h @@ -29,7 +29,6 @@ #ifndef __ASM_ARCH_OMAP_3430SDP_H #define __ASM_ARCH_OMAP_3430SDP_H -extern void sdp3430_usb_init(void); extern void sdp3430_flash_init(void); #define DEBUG_BASE 0x08000000 /* debug board */ -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html