----- Original Message -----
From: "Felipe Balbi" <me@xxxxxxxxxxxxxxx>
To: "Madhusudhan Chikkature" <madhu.cr@xxxxxx>
Cc: <tony@xxxxxxxxxxx>; <linux-omap@xxxxxxxxxxxxxxx>
Sent: Thursday, July 03, 2008 6:38 PM
Subject: Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
>
>
> On Thu, 3 Jul 2008 17:35:50 +0530 (IST), "Madhusudhan Chikkature"
> <madhu.cr@xxxxxx> wrote:
>
>> Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
>> ===================================================================
>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>> +++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03
> 16:59:40.000000000
>> +0530
>> @@ -0,0 +1,34 @@
>> +/*
>> + * linux/arch/arm/mach-omap2/board-3430sdp-bci.c
>
> just fix this name please.
Okay. I missed this one. I will correct it.
>
> Style only.
What does this mean?
>
>
>> +
>> +static struct platform_device twl4030_bci_battery_device = {
>> + .name = "twl4030-bci-battery",
>> + .id = 1,
>
> use -1. There will be no other twl4030-bci-battery in the system :-)
>
> --
> Best Regards,
>
> Felipe Balbi
> http://blog.felipebalbi.com
> me@xxxxxxxxxxxxxxx
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
