I just saw that discussion and I agree. Let's leave the patch as it is. Steve On Wed, Apr 30, 2008 at 6:14 AM, Syed Mohammed, Khasim <khasim@xxxxxx> wrote: > > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Steve Sakoman > > Sent: Wednesday, April 30, 2008 6:38 PM > > To: linux-omap@xxxxxxxxxxxxxxx; Felipe Balbi > > Subject: Re: [PATCH 4/7] OMAP3 EVM: add onenand flash support > > > > On Wed, Apr 30, 2008 at 1:35 AM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote: > > > > > > + .name = "xloader", > > > > + .offset = 0, > > > > + .size = 4*(64*2048), > > > > > > should be .size = SZ_512k, > > > > OK, will do. > > > > Sakoman, > > No need to re-work on this patch, as Richard mentioned they all depend on the geometry of the flash and might not meet the defined macros. > > Regards, > Khasim > > > > > > + .name = "uboot", > > > > + .offset = MTDPART_OFS_APPEND, > > > > + .size = 15*(64*2048), > > > > > > most of the boards use .size = SZ_128K here > > > > This seemed strange to me too, but this is the way the board ships so > > I was hesitant to change it. A change here will require changes to > > u-boot reflash scripts, etc. Might cause a bit of confusion! What do > > others think? > > > > > > + .name = "params", > > > > + .offset = MTDPART_OFS_APPEND, > > > > + .size = 1*(64*2048), > > > > > > SZ_128K > > > > OK, will do. > > > > > > + .name = "linux", > > > > + .offset = MTDPART_OFS_APPEND, > > > > + .size = 40*(64*2048), > > > > > > This looks too big for kernel only. > > > SZ_4M is way enough. > > > > Same comment as above. I am hesitant to change this without more > > discussion here. But I agree that it makes sense :-) > > > > Thanks! > > > > Steve > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
