On Tue, Apr 29, 2008 at 5:00 AM, Steve Sakoman <sakoman@xxxxxxxxx> wrote: > From: Steve Sakoman <steve@xxxxxxxxxxx> > > Add LCD support for OMAP3 EVM > > Signed-off-by: Steve Sakoman <steve@xxxxxxxxxxx> > --- > @@ -0,0 +1,168 @@ > +/* > + * LCD panel support for the TI OMAP3 EVM board > + * > + * Author: Steve Sakoman <steve@xxxxxxxxxxx> > + * > + * Derived from drivers/video/omap/lcd-apollon.c > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. > + */ > + > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/i2c/twl4030.h> > + > +#include <asm/arch/gpio.h> > +#include <asm/arch/mux.h> > +#include <asm/arch/omapfb.h> > +#include <asm/mach-types.h> > + > +#define LCD_PANEL_ENABLE_GPIO 153 > +#define LCD_PANEL_LR 2 > +#define LCD_PANEL_UD 3 > +#define LCD_PANEL_INI 152 > +#define LCD_PANEL_QVGA 154 > +#define LCD_PANEL_RESB 155 > + > +#define LCD_XRES 480 > +#define LCD_YRES 640 > +#define LCD_PIXCLOCK_MAX 41700 /* in pico seconds */ > +#define LCD_PIXCLOCK_MIN 38000 /* in pico seconds */ > + > +#define ENABLE_VDAC_DEDICATED 0x03 > +#define ENABLE_VDAC_DEV_GRP 0x20 > +#define ENABLE_VPLL2_DEDICATED 0x05 > +#define ENABLE_VPLL2_DEV_GRP 0xE0 > + I did not see you calling the below function any ware in this file, does this definition really required? > +extern void omap2_disp_replication_enable (void); Regards, Arun C -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html