Re: [PATCH] PRCM: Combine 34xx l3_icks and l4_icks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"ext Felipe Balbi" <me@xxxxxxxxxxxxxxx> writes:

> On Mon, 28 Apr 2008 11:29:53 +0300, jouni.hogander@xxxxxxxxx (Högander
> Jouni) wrote:
>> E.g dss_l3_ick and dss_l4_ick have same gating control. Having own
>> clock for both of them causes race condition between enable / disable.
>> 
>> This patch combines this kind of clocks and names new clock as
>> <module>_ick.
>> 
>> Signed-off-by: Jouni Hogander <jouni.hogander@xxxxxxxxx>
>
> Good, the following patch fixes ehci-omap.c after clock name change
> :-)

Sorry, I should have used grep here. I did it now. There are no
other references to changed clock names than this you pointed out. I
checked caḿ_l3_ick, cam_l4_ick, usbhost_l3_ick, usbhost_l4_ick.

Yes, your patch needs to be applied if "[PATCH] PRCM: Combine 34xx
l3_icks and l4_icks" is applied.

>
> Could you check, please:
>
> From 4102f3ad5db10e662633c0f9ddee6aca43fec8e6 Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> Date: Mon, 28 Apr 2008 13:45:49 +0300
> Subject: [PATCH] USB: EHCI: Fix clock name for ehci-omap.c
> MIME-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: 8bit
>
> Patch from Jouni Högander changed usbhost_l4_ick to
> usbhost_ick, fixing in ehci-omap.c
>
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> Cc: Jouni Högander <jouni.hogander@xxxxxxxxx>
> ---
>  drivers/usb/host/ehci-omap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 495c979..be93c69 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -73,7 +73,7 @@ struct ehci_omap_clock_defs {
>  };
>  
>  /* Clock names as per clock framework: May change so keep as #defs */
> -#define USBHOST_ICKL	"usbhost_l4_ick"
> +#define USBHOST_ICKL	"usbhost_ick"
>  #define USBHOST_120M_FCLK	"usbhost_120m_fck"
>  #define USBHOST_48M_FCLK	"usbhost_48m_fck"
>  #define USBHOST_TLL_ICKL	"usbtll_ick"
> -- 
> 1.5.5.1.57.g5909c
>
>
>
> -- 
> Best Regards,
>
> Felipe Balbi
> http://felipebalbi.com
> me@xxxxxxxxxxxxxxx
>

-- 
Jouni Högander

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux