Looks better to me, but:
On Thursday 24 April 2008, Felipe Balbi wrote:
> +static void setup_ehci_io_mux(void)
> +{
> +#ifdef CONFIG_OMAP_EHCI_PHY_MODE
This PHY_MODE thing should probably be provided by the board
data not Kconfig, and
> + /* PHY mode of operation for board: 750-2083-001
> + * ISP1504 connected to Port1 and Port2
> + * Do Func Mux setting for 12-pin ULPI PHY mode
> + */
> +
> + /* Port1 */
> + omap_cfg_reg(Y9_3430_USB1HS_PHY_STP);
> + omap_cfg_reg(Y8_3430_USB1HS_PHY_CLK);
> ...
All those MUX options should be driven by the board data too.
Unless it's for some reason not possible to configure only one
of the three EHCI ports at a time...
This patch being cleanup-only, I don't suggest you fix that
at this time.
- Dave
> +
> +#else
> + /* Set Func mux for :
> + * TLL mode of operation
> + * 12-pin ULPI SDR TLL mode for Port1/2/3
> + */
> +
> + /* Port1 */
> + omap_cfg_reg(Y9_3430_USB1HS_TLL_STP);
> + omap_cfg_reg(Y8_3430_USB1HS_TLL_CLK);
> + ...
> +#endif /* CONFIG_OMAP_EHCI_PHY_MODE */
> +
> + return;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
