Re: [PATCH 1/5] Powerdomains: add OMAP chip type global bitfield; clean up mach-omap2/id.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>Add a new kind of OMAP identification, omap_chip.  omap_chip is a
>bitfield which contains one bit for each OMAP2/3 CPU type, and, on
>3430 and beyond, ES level.  
>
>For example, the CHIP_IS_OMAP2420 bit is set in omap_type at boot on
>an OMAP2420.  On OMAP3430ES2, both CHIP_IS_OMAP3430 and
>CHIP_IS_OMAP3430ES2 bits are set.
>
>omap_chip is set in mach-omap2/id.c by _set_omap_chip().  omap_chip is
>declared static to prevent external code from accessing it directly.
>Other code can test against omap_chip via the omap_chip_is() function.

Omap chip is not set correctly in case of omap3 es2.x. You should
change your code something like this:

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 77b4f34..3523f62 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -229,6 +229,7 @@ void __init omap2_check_revision(void)
 	if (hawkeye == 0xb7ae) {
 		system_rev = 0x34300000 | ((1 + rev) << 12);
 		pr_info("OMAP%04x ES2.%i\n", system_rev >> 16, rev);
+		_set_omap_chip();
 		return;
 	}
-- 
Jouni Högander

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux