On Thu, 10 Apr 2008 11:45:32 -0600 (MDT), Paul Walmsley <paul@xxxxxxxxx> wrote: > > This patch fixes the "musb_hdrc: invalid ep 8" messages that show up on > boot with current linux-omap git head on OMAP3430SDP ES2.1. I guess that > the musb driver comes up in FIFO mode 4 with 16 endpoints defined, but the > driver is limited to 8 endpoints by macros in hdrc_cnf.h. > > Anyway, I don't know much about MUSB. David or Felipe, maybe you could > take a quick look at this patch? I had this same patch queued for sending but i was waiting until i finished a whole series for musb driver. :-) It's acked, if dave doesn't have any comments i think it should be applied. > > > Signed-off-by: Paul Walmsley <paul@xxxxxxxxx> Acked-by Felipe Balbi <felipe.balbi@xxxxxxxxx> > > --- > include/asm-arm/arch-omap/hdrc_cnf.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h > =================================================================== > --- linux-omap.orig/include/asm-arm/arch-omap/hdrc_cnf.h 2007-08-27 > 02:19:07.000000000 -0600 > +++ linux-omap/include/asm-arm/arch-omap/hdrc_cnf.h 2008-04-01 > 11:10:34.000000000 -0600 > @@ -14,11 +14,11 @@ > > /* ** Number of Tx endpoints ** */ > /* Legal values are 1 - 16 (this value includes EP0) */ > -#define MUSB_C_NUM_EPT 8 > +#define MUSB_C_NUM_EPT 16 > > /* ** Number of Rx endpoints ** */ > /* Legal values are 1 - 16 (this value includes EP0) */ > -#define MUSB_C_NUM_EPR 8 > +#define MUSB_C_NUM_EPR 16 > > /* ** Endpoint 1 to 15 direction types ** */ > /* C_EP1_DEF is defined if either Tx endpoint 1 or Rx endpoint 1 are used > */ > @@ -163,7 +163,7 @@ > * Legal values are 2 - 16 > * This must be equal to the larger of C_NUM_EPT, C_NUM_EPR > */ > -#define MUSB_C_NUM_EPS 8 > +#define MUSB_C_NUM_EPS 16 > > /* C_EPMAX_BITS is equal to the largest endpoint FIFO word address bits > */ > #define MUSB_C_EPMAX_BITS 12 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Felipe Balbi http://felipebalbi.com me@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
