Hi Daniel,
On Wed, Apr 9, 2008 at 2:02 PM, Daniel Stone <daniel.stone@xxxxxxxxx> wrote:
> Hi,
>
>
> On Wed, Apr 09, 2008 at 01:54:16PM +0300, ext Eduardo Valentin wrote:
> > ERROR: do not initialise statics to 0 or NULL
>
> > WARNING: braces {} are not necessary for single statement blocks
>
> Yeah, these should be fixed.
>
>
> > WARNING: consider using strict_strtoul in preference to simple_strtoul
> > WARNING: consider using strict_strtoul in preference to simple_strtoul
>
> I don't even know what strict_strtoul is, but okay.
>
>
> > WARNING: line over 80 characters
>
> > WARNING: do not add new typedefs
>
> Sure.
>
>
> > daniel.diff has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> >
> >
> > I'd suggest using some #defines for lots for magic numbers in this code.
>
> 'lots'? The only ones I can see are the magic constant needed for reset
> (used in one place and commented), and the default/max values for
> debounce/active time, and max x/y, both of which are again only used in
> a single place.
That's true. But, IMHO they still make the code difficult to read.
>
> Cheers,
> Daniel
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFH/KJg68xJuWtYYdURAlUQAKCGvDHvm1DvmmIavnztgedxQj8pfACfVaEJ
> GMOOUOVCzTEm7ULxwz5PE/Q=
> =U9pC
> -----END PGP SIGNATURE-----
>
>
--
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
