Hi Balbi and Mathias,
This patch has some style problems. Here is the output of checkpatch:
evalenti@evalenti-desktop:~$
./trees/linux-omap-2.6/scripts/checkpatch.pl mathias.diff
ERROR: do not use assignment in if condition
#314: FILE: drivers/i2c/chips/tsl2563.c:188:
+ if ((ret = tsl2563_write(client, TSL2563_REG_TIMING,
ERROR: do not use assignment in if condition
#328: FILE: drivers/i2c/chips/tsl2563.c:202:
+ if ((ret = tsl2563_set_power(chip, 1)))
ERROR: do not use assignment in if condition
#727: FILE: drivers/i2c/chips/tsl2563.c:601:
+ if (!(chip = kzalloc(sizeof(*chip), GFP_KERNEL)))
ERROR: do not use assignment in if condition
#733: FILE: drivers/i2c/chips/tsl2563.c:607:
+ if ((err = tsl2563_detect(chip))) {
ERROR: do not use assignment in if condition
#738: FILE: drivers/i2c/chips/tsl2563.c:612:
+ if ((err = tsl2563_read_id(chip, &id)))
ERROR: do not use assignment in if condition
#753: FILE: drivers/i2c/chips/tsl2563.c:627:
+ if ((err = tsl2563_configure(chip)))
ERROR: do not use assignment in if condition
#760: FILE: drivers/i2c/chips/tsl2563.c:634:
+ if ((err = tsl2563_register_sysfs(client))) {
ERROR: do not use assignment in if condition
#791: FILE: drivers/i2c/chips/tsl2563.c:665:
+ if ((ret = tsl2563_set_power(chip, 0)))
ERROR: do not use assignment in if condition
#808: FILE: drivers/i2c/chips/tsl2563.c:682:
+ if ((ret = tsl2563_set_power(chip, 1)))
ERROR: do not use assignment in if condition
#811: FILE: drivers/i2c/chips/tsl2563.c:685:
+ if ((ret = tsl2563_configure(chip)))
total: 10 errors, 0 warnings, 756 lines checked
mathias.diff has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
On Wed, Apr 9, 2008 at 1:09 PM, Felipe Balbi <felipe.balbi@xxxxxxxxx> wrote:
>
> From: Mathias Nyman <mathias.nyman@xxxxxxxxx>
>
<snip>
> +
> +/*--------------------------------------------------------------*/
> +/* Sysfs interface */
> +/*--------------------------------------------------------------*/
Use correct multiple lines comments style here.
> +
> +static ssize_t tsl2563_adc0_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
<snip>
> +
> +/*--------------------------------------------------------------*/
> +/* Probe, Attach, Remove */
> +/*--------------------------------------------------------------*/
Previous comment applies here as well.
> +static struct i2c_driver tsl2563_i2c_driver;
> +
<snip>
Cheers,
--
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
