On Tue, Mar 18, 2008 at 04:02:03PM +0200, Tony Lindgren wrote:
> From: Paul Walmsley <paul@xxxxxxxxx>
>
> This patch changes 24xx to use new register access, except for clock
> framework. Clock framework register access will get updates in the
> next patch.
Hmm...
> @@ -187,13 +189,40 @@ static inline void __init apollon_init_smc91x(void)
> {
> unsigned long base;
>
> + unsigned int rate;
> + struct clk *l3ck;
> + int eth_cs;
> +
> + l3ck = clk_get(NULL, "core_l3_ck");
> + if (IS_ERR(l3ck))
> + rate = 100000000;
> + else
> + rate = clk_get_rate(l3ck);
Now read:
/**
* clk_get_rate - obtain the current clock rate (in Hz) for a clock source.
* This is only valid once the clock source has been enabled.
* @clk: clock source
*/
unsigned long clk_get_rate(struct clk *clk);
And now tell me what's wrong with the above code.
> + int eth_cs;
> + unsigned long cs_mem_base;
> + unsigned int muxed, rate;
> + struct clk *l3ck;
> +
> + eth_cs = H4_SMC91X_CS;
> +
> + l3ck = clk_get(NULL, "core_l3_ck");
> + if (IS_ERR(l3ck))
> + rate = 100000000;
> + else
> + rate = clk_get_rate(l3ck);
Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
