Re: Unnecessary line in omapfb_main.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* arun c <arunedarath@xxxxxxxxxxxxxxxxxxxx> [080325 11:11]:
> Hi all,
> 
> While grepping through the sources i found one unnecessary line in
> omapfb_main.c
> 
> The patch is pasted below.
> 
> diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c
> index f66b81a..07eb3f0 100644
> --- a/drivers/video/omap/omapfb_main.c
> +++ b/drivers/video/omap/omapfb_main.c
> @@ -559,7 +559,6 @@ static int set_fb_var(struct fb_info *fbi,
>  		var->xoffset = var->xres_virtual - var->xres;
>  	if (var->yres + var->yoffset > var->yres_virtual)
>  		var->yoffset = var->yres_virtual - var->yres;
> -	line_size = var->xres * bpp / 8;
> 
>  	if (plane->color_mode == OMAPFB_COLOR_RGB444) {
>  		var->red.offset	  = 8; var->red.length	 = 4;

Indeed looks like dead code as line_size is not used after that line
:) Can you please send the patch with proper Signed-off-by?

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux