On Thu, Mar 20, 2008 at 10:25:01AM -0400, Carlos Aguiar wrote:
> if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> - if (mmc->enabled)
> + mmc = &mmc_conf->mmc[1];
> + if (mmc->enabled) {
> (void) platform_device_register(&mmc_omap_device1);
> + (void) platform_device_register(&mmc_omap_device2);
> + }
Shouldn't you only register each device if enabled in the corresponding
configuration, i.e.:
if (mmc_conf->mmc[1].enabled)
(void) platform_device_register(&mmc_omap_device1);
if (mmc_conf->mmc[2].enabled)
(void) platform_device_register(&mmc_omap_device2);
It looks to me like, with this patch applied, no MMC devices will be
registered with the current board-2430sdp.c.
Otherwise I'd say this looks like an improvement over what I worked up (I
overlooked the section quoted above, which would have saved me the trouble of
working out the muxings).
Cheers,
Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
