> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Tony > Lindgren > Sent: Saturday, March 01, 2008 12:23 AM > To: Jarkko Nikula > Cc: ext Kyungmin Park; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ARM: OMAP: Remove compiler warning when i2c is not set > > * Jarkko Nikula <jarkko.nikula@xxxxxxxxx> [080228 23:06]: > > On Fri, 29 Feb 2008 08:12:05 +0900 > > "ext Kyungmin Park" <kyungmin.park@xxxxxxxxxxx> wrote: > > > > > Remove compiler warning when i2c is not set > > > > > > #else > > > -#define omap_register_i2c_bus(a, b, c, d) 0 > > > +#define omap_register_i2c_bus(a, b, c, d) do { } while (0) > > > #endif > > > > > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxx> > > > > Tony, this patch should go to upstream fixes as well. > > > > --- > > > > Hmm, I'm wondering what was wrong with Kyungmin's original fix > > d87e74e67b5285e52c986e1c1be20b4107060985? It was changed to > > > > -#define omap_register_i2c_bus(...) do { } while (0) > > +#define omap_register_i2c_bus(a, b, c, d) 0 > > > > by commit bbe976ce41fbe5fd0e402b71349271c1fe599043 > > > > Author: Tony Lindgren <tony@xxxxxxxxxxx> > > Date: Mon Jan 14 17:22:31 2008 -0800 > > > > ARM: OMAP: Misc fixes based on RMK's comments > > Hmm, are you guys sure about this? Wondering because > omap_register_i2c_bus() returns int, no? > Yes, omap_register_i2c_bus returns int but there's no user. It seems working as void :) Then how about to define as inline? Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
