* David Brownell <david-b@xxxxxxxxxxx> [080226 11:11]:
> Remove false lockdep warnings about lock recursion when declaring
> IRQs as being wake-capable, by marking putting GPIO irq_desc locks
> into their own class.
>
> (Thanks to Peter Zijlstra for helping track down such a small
> fix to this problem.)
>
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
> NOTE: the false warnings are in both mainline and the OMAP tree.
>
> arch/arm/plat-omap/gpio.c | 6 ++++++
> 1 files changed, 6 insertions(+)
>
> --- a/arch/arm/plat-omap/gpio.c 2008-02-25 14:03:04.000000000 -0800
> +++ b/arch/arm/plat-omap/gpio.c 2008-02-26 11:03:34.000000000 -0800
> @@ -1332,6 +1332,11 @@ static struct clk *gpio_fclks[OMAP34XX_N
> static struct clk *gpio_iclks[OMAP34XX_NR_GPIOS];
> #endif
>
> +/* This lock class tells lockdep that GPIO irqs are in a different
> + * category than their parents, so it won't report false recursion.
> + */
> +static struct lock_class_key gpio_lock_class;
> +
> static int __init _omap_gpio_init(void)
> {
> int i;
> @@ -1525,6 +1530,7 @@ static int __init _omap_gpio_init(void)
>
> for (j = bank->virtual_irq_start;
> j < bank->virtual_irq_start + gpio_count; j++) {
> + lockdep_set_class(&irq_desc[j].lock, &gpio_lock_class);
> set_irq_chip_data(j, bank);
> if (bank_is_mpuio(bank))
> set_irq_chip(j, &mpuio_irq_chip);
Pushing today & adding to omap-fixes queue.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
