* David Cohen <dacohen@xxxxxxxxx> [080207 07:22]: > On Feb 7, 2008 5:52 AM, Pandita, Vikram <vikram.pandita@xxxxxx> wrote: > > Hi David Cohen > > > > >-----Original Message----- > > >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of David > > >Subject: [PATCH 1/3] ARCH: OMAP: Fixing MUX_CFG_34XX macro. > > > > > >If CONFIG_OMAP_MUX_DEBUG and CONFIG_OMAP_MUX_WARNING are not set, the debug > > >member is not declared on pin_config struct and should not be used on > > >MUX_CFG_34XX macro. > > > > > >Signed-off-by: David Cohen <david.cohen@xxxxxxxxxxx> > > >--- > > > include/asm-arm/arch-omap/mux.h | 8 ++++++++ > > > 1 files changed, 8 insertions(+), 0 deletions(-) > > > > > >diff --git a/include/asm-arm/arch-omap/mux.h b/include/asm-arm/arch-omap/mux.h > > >index e5a96c3..fbdc6e5 100644 > > >--- a/include/asm-arm/arch-omap/mux.h > > >+++ b/include/asm-arm/arch-omap/mux.h > > >@@ -166,12 +166,20 @@ > > > #define OMAP34XX_PIN_OFF_INPUT_PULLDOWN (OMAP3_OFF_EN | OMAP3_OFF_PULL_EN) > > > #define OMAP34XX_PIN_OFF_WAKEUPENABLE OMAP3_WAKEUP_EN > > > > > >+#if defined(CONFIG_OMAP_MUX_DEBUG) || defined(CONFIG_OMAP_MUX_WARNINGS) > > > #define MUX_CFG_34XX(desc, reg_offset, mux_value){ \ > > > .name = desc, \ > > > .debug = 0, \ > > > > Do we want to default debug = 1 whenever OMAP_MUX_DEBUG or OMAP_MUX_WARNINGS is defined. > > Else I would suggest here > > .debug = 1, > > It makes sense, once these macros aim to enable debug. I agree debug = > 1. What do you think, Tony? Well it used to be that debug option was there instead of CONFIG_OMAP_MUX_DEBUG. We may be able to use just CONFIG_OMAP_MUX_DEBUG and get rid of debug. But that needs to be tested with all the boards, especially serial console port gets easily hosed. Tony - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
