* David Cohen <dacohen@xxxxxxxxx> [080205 22:17]:
> Hi,
>
> On Feb 6, 2008 12:49 AM, Suresh Rajashekara <suresh@xxxxxxxxxxxxxxxxxxxx> wrote:
> > The structure member debug is put inside a macro for conditional compilation,
> > but other macro's using it are not under any such conditional compilation
> > macro. This make the build fail for OMAP2430 SDP (omap_2430sdp_defconfig). I am
> > not sure if this is the right way to fix this.
> >
> >
> > Signed-off-by: Suresh Rajashekara <suresh@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > include/asm-arm/arch-omap/mux.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/asm-arm/arch-omap/mux.h b/include/asm-arm/arch-omap/mux.h
> > index e5a96c3..fc869c0 100644
> > --- a/include/asm-arm/arch-omap/mux.h
> > +++ b/include/asm-arm/arch-omap/mux.h
> > @@ -195,8 +195,8 @@ struct pin_config {
> > const unsigned char pu_pd_val;
> > #endif
> >
> > -#if defined(CONFIG_OMAP_MUX_DEBUG) || defined(CONFIG_OMAP_MUX_WARNINGS)
> > unsigned char debug;
> > +#if defined(CONFIG_OMAP_MUX_DEBUG) || defined(CONFIG_OMAP_MUX_WARNINGS)
> > const char *mux_reg_name;
> > #endif
>
> The problem here is when MUX_DEBUG and MUX_WARNING is not set, the
> debug fied is still being used somewhere. But you're not fixing it,
> instead you are allowing to use this field when it shouldn't be
> compiled.
> I'm sending a patch to deal with in a different way.
I already pushed a similar fix. But the long term fix would be to
tweak the macros so debug field is only used with debug.
Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
