>-----Original Message----- >From: Klaus.K Pedersen (Nokia-M/Helsinki) >> ... >> > I havn't seen the patch in detail. But, I tried this patch >on my keypad layout(t2 keypad matrix). There is some strange behaviour. >> > If I keep pressing the keys one after the other, at some point of >> > time I get suppurious key code/dumps some invalid key code >values(?). Have you noticed this? > >Did the patch solve your problem? Sorry for late reply. Well, I tried with that change but still I find some suppurious keys coming in. Find the following log, this might give a clear picture. omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-2 omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-3 omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-4 time=946684925 sec 852447 microsec,code=106,value=1 time=946684925 sec 852447 microsec,code=49,value=0 omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-2 omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-3 omap_twl4030keypad omap_twl4030keypad: Spurious key event 6-4 time=946684925 sec 968048 microsec,code=106,value=0 >> Try to add the attached patch (or change): >> >> if (col == 0xFF) >> return (1 << n_cols); >> else >> - return col; >> + return col & ((1 << n_cols) - 1); >> >> BR, Klaus >> >> >> > Regards, >> > Girish >> > > - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html