David >-----Original Message----- >From: David Brownell [mailto:david-b@xxxxxxxxxxx] >Subject: Re: [PATCH 2/2] REWOKED: patch adds the EHCI glue layer to 34xx platform and menu config >items > >On Tuesday 29 January 2008, Pandita, Vikram wrote: >> arch/arm/mach-omap2/cm.h | 24 + >> arch/arm/mach-omap2/cm_regbits_34xx.h | 37 ++ >> arch/arm/mach-omap2/prm.h | 10 Will split the patch and resend as set of 3 patchs Prm-cm-changes-patch Board-file-changes-patch Ehci-driver-changes-patch > >This should be split into two patches ... right about here. >(By the way, your patch had bogus diffstat output. The next >three lines were partially duplicated...) quilt refresh --diffstat : appends the diffstat, will take care next time > > >> drivers/usb/Kconfig | 1 >> drivers/usb/host/Kconfig | 19 + >> drivers/usb/host/ehci-hcd.c | 5 >> drivers/usb/host/ehci-omap.c | 557 ++++++++++++++++++++++++++++++++++ >> drivers/usb/host/ehci-omap.h | 116 +++++++ > >In general, patches should be split out so the arch/arm/... and >the include/asm-arm/... updates are separate from drivers/... updates. > >Because when they go upstream, those will be separate patches ... and >will normally merge through separate maintainers. It may matter less >on this particular patch ... but I can say that the EHCI parts of this >one won't get reviewed, whle an EHCI-only patch would at least get put >in my review queue. OK > >- Dave - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
