Re: Patch for MMC driver on SDP2430

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

The PRCM (0x490022E8)register was overwritten by the MMC code
which made the other peripherals like USB etc to stop working.
The following patch fixes the modification of PRCM register by the  MMC
 code . This patch is tested here on the OMAP2430 SDP board. 
File:
	arch/arm/mach-omap2/board-sdp-hsmmc.c


Description: This patch  fixes the unwanted PRCM register writes
Signed-off-by: Arun K S <arunks@xxxxxxxxxxxxxxxxxxxx>
Ack-by: Madhusudhan Chikkature Rajashekar" <madhu.cr@xxxxxx>

>From 1e7097cdd9831c39a2e402fdbaea80062d04fb2b Mon Sep 17 00:00:00 2001
From: Arun K S <arunks@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 28 Jan 2008 20:34:57 +0530
Subject: [PATCH] omap2430sdp_mmc_fix

---
 arch/arm/mach-omap2/board-sdp-hsmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-sdp-hsmmc.c 
b/arch/arm/mach-omap2/board-sdp-hsmmc.c
index 4bf8165..90e8def 100644
--- a/arch/arm/mach-omap2/board-sdp-hsmmc.c
+++ b/arch/arm/mach-omap2/board-sdp-hsmmc.c
@@ -176,7 +176,7 @@ static int sdp_mmc_set_power(struct device *dev, int slot, 
int power_on,
                case MMC_VDD_32_33:
                        vdd_sel = VSEL_3V;
                        if (cpu_is_omap24xx())
-                               devconf = (reg | (1 << 31));
+                               devconf = (devconf | (1 << 31));
                        break;
                case MMC_VDD_165_195:
                        vdd_sel = VSEL_18V;
--
1.5.3.7

Regards
Arun K S
	

On Tuesday 29 January 2008 14:24, you wrote:
> Hi Arun,
>
> ACK.
>
> That is a good catch. Could you please send the patch again with a
> signed-off line.
>
> Regards,
> Madhusudhan.
>
> > -----Original Message-----
> > From: linux-omap-owner@xxxxxxxxxxxxxxx
> > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Arun K S
> > Sent: Monday, January 28, 2008 8:52 PM
> > To: linux-omap@xxxxxxxxxxxxxxx
> > Subject: Patch for MMC driver on SDP2430
> >
> > Hi,
> >
> > The PRCM (0x490022E8)register was overwritten by the MMC code
> > which made the
> > other peripherals like USB etc to stop working.
> > The following patch fixes the modification of PRCM register
> > by the  MMC
> > code .
> > This patch is tested here on the OMAP2430 SDP board.
> > Following is the Patch against the latest GIT Sources of Linux-omap:
> >
> > ---
> >  arch/arm/mach-omap2/board-sdp-hsmmc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-sdp-hsmmc.c
> > b/arch/arm/mach-omap2/board-sdp-hsmmc.c
> > index 4bf8165..90e8def 100644
> > --- a/arch/arm/mach-omap2/board-sdp-hsmmc.c
> > +++ b/arch/arm/mach-omap2/board-sdp-hsmmc.c
> > @@ -176,7 +176,7 @@ static int sdp_mmc_set_power(struct
> > device *dev, int slot,
> > int power_on,
> >                 case MMC_VDD_32_33:
> >                         vdd_sel = VSEL_3V;
> >                         if (cpu_is_omap24xx())
> > -                               devconf = (reg | (1 << 31));
> > +                               devconf = (devconf | (1 << 31));
> >                         break;
> >                 case MMC_VDD_165_195:
> >                         vdd_sel = VSEL_18V;
> > --
> > 1.5.3.7
> > Signed-off-by: Arun K.S <arunks@xxxxxxxxxxxxxxxxxxxx>
> >
> >
> >
> > Thanks and Regards
> > Arun KS
> >
> >
> > -------------------------------------------------------DISCLAI
> > MER------------------------------------------------------
> > The information transmitted herewith is confidential and
> > proprietary information intended only for use by the
> > individual or entity to which it is addressed. If the reader
> > of this message is not the intended recipient, you are hereby
> > notified that any review, retransmission, dissemination,
> > distribution, copying or other use of, or taking of any
> > action in reliance upon this information is strictly
> > prohibited. If you have received this communication in error,
> > please contact the sender and delete the material from your computer.
> > --------------------------------------------------------------
> > ------------------------------------------------------------------
> >
> > Please do not print this email unless it is absolutely
> > necessary. Spread environmental awareness.
> >
> >
> >
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-omap" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-------------------------------------------------------DISCLAIMER------------------------------------------------------
The information transmitted herewith is confidential and proprietary information intended only for use by the individual or entity to which it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.
--------------------------------------------------------------------------------------------------------------------------------

Please do not print this email unless it is absolutely necessary. Spread environmental awareness.


-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux