ext Chandra shekhar wrote: > Changing CONFIG_I2C_TWL4030_ID to 2 will break the existing 3430 platform. > > There should be check for 2430 or 3430 SDP. > > #ifdef CONFIG_MACH_OMAP_3430SDP > #define CONFIG_I2C_TWL4030_ID 1 > #elif CONFIG_MACH_OMAP_2430SDP > #define CONFIG_I2C_TWL4030_ID 2 > #endif > > >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Carlos Aguiar >> Sent: Monday, January 28, 2008 7:04 PM >> To: Tony Lindgren >> Cc: linux-omap@xxxxxxxxxxxxxxx >> Subject: [PATCH 1/1] I2C: TWL4030: Fix some TWL4030 failures >> and makes MMC work properly on 2430 boards >> >> From: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx> >> >> This simple patch fix some TWL4030 failures and makes MMC >> work properly on 2430 boards. >> >> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@xxxxxxxxxxx> >> Signed-off-by: Madhusudhan Chikkature <madhu.cr@xxxxxx> >> Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxxxx> >> --- >> drivers/i2c/chips/twl4030_core.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/i2c/chips/twl4030_core.c >> b/drivers/i2c/chips/twl4030_core.c >> index e733195..8e49206 100644 >> --- a/drivers/i2c/chips/twl4030_core.c >> +++ b/drivers/i2c/chips/twl4030_core.c >> @@ -130,7 +130,7 @@ >> #define HIGH_PERF_SQ (1 << 3) >> >> /* on I2C-1 for 2430SDP */ >> -#define CONFIG_I2C_TWL4030_ID 1 >> +#define CONFIG_I2C_TWL4030_ID 2 >> >> /* Helper functions */ >> static int >> -- 1.5.3.GIT >> >> - >> To unsubscribe from this list: send the line "unsubscribe >> linux-omap" in the body of a message to >> majordomo@xxxxxxxxxxxxxxx More majordomo info at >> http://vger.kernel.org/majordomo-info.html >> >> > > - > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Hum, Sorry folks, I have only a 2430 board here. So, I'll resend the patch with the check proposed by Chandra. BR, Carlos. -- Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: carlos.aguiar@xxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
