* Eduardo Valentin <edubezval@xxxxxxxxx> [071223 19:46]:
> Hi Madhusudhan,
>
> Thanks for your good patch. I have some suggestions:
>
> On Dec 20, 2007 6:04 AM, Madhusudhan Chikkature Rajashekar
> <madhu.cr@xxxxxx> wrote:
> > This patch registers the MMC device for OMAP2430/3430.
> >
> > Signed-off-by: Madhusudhan Chikkature<madhu.cr@xxxxxx>
> >
> > ---
> > arch/arm/plat-omap/devices.c | 18 ++++++++++++------
> > 1 files changed, 12 insertions(+), 6 deletions(-)
> >
> > Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
> > ===================================================================
> > --- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c 2007-12-18 17:35:45.578743000 +0530
> > +++ linux-omap-2.6/arch/arm/plat-omap/devices.c 2007-12-20 11:19:42.970456249 +0530
> > @@ -19,6 +19,7 @@
> > #include <asm/mach-types.h>
> > #include <asm/mach/map.h>
> >
> > +#include <asm/arch/mmc.h>
> Do not duplicate #include.
> > #include <asm/arch/tc.h>
> > #include <asm/arch/board.h>
> > #include <asm/arch/mmc.h>
>
> See? It is already there! :)
I took the extra define out.
...
> > #else
> I believe it is better to change this function to be static inline.
> > +void omap_set_mmc_info(int host, const struct omap_mmc_platform_data *info) {}
And made this static.
Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
