Re: [PATCH] fix numactl test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/2015 04:29 PM, Filipe Brandenburger wrote:
> Hi Rick,
> 
> On Sun, May 3, 2015 at 7:35 PM, Rick "Zero_Chaos" Farina
> <zerochaos@xxxxxxxxxx> wrote:
>> I apologize if this is already handled, however, a quick google search
>> didn't help me find any version control systems so I'm submitting here.
> 
> The numactl sources have been recently uploaded to this git repository:
> https://github.com/numactl/numactl
> 
>> In Gentoo we got a bug, where numactl fails tests if it isn't already
>> installed:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=502586
>>
>> ./bind_range: line 92: numactl: command not found
>> ./bind_range: line 93: numactl: command not found
>>
>> The origin is fairly trivial, it appears that on the noted lines it's
>> calling "numactl" instead of "../numactl" like it should.  Which means
>> it will try to use an installed numactl (possibly older) and fail if it
>> isn't installed at all.
> 
> Yes, this was fixed in this commit:
> https://github.com/numactl/numactl/commit/25c052affbbcd2df0f67376d18d3ac4028326175
> 
> It's more general, as it adds the build directory to $PATH and it also
> works when an out-of-tree build is used.
> 
> May I suggest that you upgrade to the latest 2.0.10 which does contain this fix?

2.0.10 has a bug related to gentoo which I haven't figured out yet
(doesn't appear to be upstream related afaict so far so don't worry
about it) so when I saw the same call to numactl in both I assumed the
bug was still there.  Glad it's fixed, thanks for the work :-)

-Zero_Chaos

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [Devices]

  Powered by Linux