Use Generic Per cpu infrastructure for numa_*_id() V4 Series Against: 2.6.34-rc3-mmotm-100405-1609 Background: V1 of this series resolved a fairly serious performance problem on our ia64 platforms with memoryless nodes because SLAB cannot cache object from a remote node, even tho' that node is the effective "local memory node" for a given cpu. V1 caused no regression in x86_64 [a slight improvement even] for the admittedly few tests that I ran. Christoph Lameter suggested the approach implemented in V2 and later: define a new function--numa_mem_id()--that returns the "local memory node" for cpus attached to memoryless nodes. Christoph also suggested that, while at it, I could modify the implementation of numa_node_id() [and the related cpu_to_node()] to use the generic percpu variable implementation. While implementing V2, I encountered a circular header dependency between: topology.h -> percpu.h -> slab.h -> gfp.h -> topology.h I resolved this by moving the generic percpu functions to include/asm-generic/percpu.h so that various arch asm/percpu.h could include that, and topology.h could include asm/percpu.h to avoid including slab.h, breaking the circular dependency. Reviewers didn't like that. Matthew Willcox suggested that I uninline percpu_alloc()/free() for the !SMP config and remove slab.h from percpu.h. I tried that. I broke the build of a LOT of files. Tejun Heo mentioned that percpu-defs.h would be a better place for the generic function definitions. V3 implemented that suggestion. Later, Tejun decided to jump in and remove slab.h from percpu.h and semi- automagically fix up all of the affected modules. V4 is implemented atop Tejun's series now in mmotm. Again, this solves the slab performance problem on our servers configured with memoryless nodes, and shows no regression with hackbench on x86_64. Of course, more performance testing would be welcome. The slab changes in patch 6 of the series need review w/rt to node hot plug that could change the effective "local memory node" for a memoryless node by inserting a "nearer" node in the zonelists. An additional patch may be required to address this. Lee -- To unsubscribe from this list: send the line "unsubscribe linux-numa" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
