Re: [PATCH 4/10] hugetlb: derive huge pages nodes allowed from task mempolicy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 5 Oct 2009, Lee Schermerhorn wrote:

> > mm/hugetlb.c: In function 'nr_hugepages_store_common':
> > mm/hugetlb.c:1368: error: storage size of '_m' isn't known
> > mm/hugetlb.c:1380: warning: passing argument 1 of 'init_nodemask_of_mempolicy' from incompatible pointer type
> > mm/hugetlb.c:1382: warning: assignment from incompatible pointer type
> > mm/hugetlb.c:1390: warning: passing argument 1 of 'init_nodemask_of_node' from incompatible pointer type
> > mm/hugetlb.c:1392: warning: passing argument 3 of 'set_max_huge_pages' from incompatible pointer type
> > mm/hugetlb.c:1394: warning: comparison of distinct pointer types lacks a cast
> > mm/hugetlb.c:1368: warning: unused variable '_m'
> > mm/hugetlb.c: In function 'hugetlb_sysctl_handler_common':
> > mm/hugetlb.c:1862: error: storage size of '_m' isn't known
> > mm/hugetlb.c:1864: warning: passing argument 1 of 'init_nodemask_of_mempolicy' from incompatible pointer type
> > mm/hugetlb.c:1866: warning: assignment from incompatible pointer type
> > mm/hugetlb.c:1868: warning: passing argument 3 of 'set_max_huge_pages' from incompatible pointer type
> > mm/hugetlb.c:1870: warning: comparison of distinct pointer types lacks a cast
> > mm/hugetlb.c:1862: warning: unused variable '_m'
> 
> 
> ??? This is after your rework of NODEMASK_ALLOC has been applied?  I
> don't see this when I build the mmotm that the patch is based on.  
> 

This was mmotm-09251435 plus this entire patchset.

You may want to check your toolchain if you don't see these errors, this 
particular patch adds NODEMASK_ALLOC(nodemask, nodes_allowed) which would 
expand out to allocating a "struct nodemask" either dynamically or on the 
stack and such an object doesn't exist in the kernel.

> Ah, but your patch didn't exist back then :).
> 
> I guess I'll tack this onto the end of V9 with a note that it depends on
> your patch.  Altho' for bisection builds, I might want to break it into
> separate patches that apply to the mempolicy and per node attributes
> patches, respectively.
> 

Feel free to just fold it into patch 4 so the series builds incrementally.
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [Devices]

  Powered by Linux