On Fri, 2 Oct 2009, Mel Gorman wrote:
> > Index: linux-2.6.31-mmotm-090925-1435/mm/hugetlb.c
> > ===================================================================
> > --- linux-2.6.31-mmotm-090925-1435.orig/mm/hugetlb.c 2009-09-30 12:48:45.000000000 -0400
> > +++ linux-2.6.31-mmotm-090925-1435/mm/hugetlb.c 2009-10-01 12:13:25.000000000 -0400
> > @@ -1334,29 +1334,71 @@ static struct hstate *kobj_to_hstate(str
> > return NULL;
> > }
> >
> > -static ssize_t nr_hugepages_show(struct kobject *kobj,
> > +static ssize_t nr_hugepages_show_common(struct kobject *kobj,
> > struct kobj_attribute *attr, char *buf)
> > {
> > struct hstate *h = kobj_to_hstate(kobj);
> > return sprintf(buf, "%lu\n", h->nr_huge_pages);
> > }
> > -static ssize_t nr_hugepages_store(struct kobject *kobj,
> > - struct kobj_attribute *attr, const char *buf, size_t count)
> > +static ssize_t nr_hugepages_store_common(bool obey_mempolicy,
> > + struct kobject *kobj, struct kobj_attribute *attr,
> > + const char *buf, size_t len)
> > {
> > int err;
> > - unsigned long input;
> > + unsigned long count;
> > struct hstate *h = kobj_to_hstate(kobj);
> > + NODEMASK_ALLOC(nodemask, nodes_allowed);
> >
> > - err = strict_strtoul(buf, 10, &input);
> > + err = strict_strtoul(buf, 10, &count);
> > if (err)
> > return 0;
> >
> > - h->max_huge_pages = set_max_huge_pages(h, input, &node_online_map);
> > + if (!(obey_mempolicy && init_nodemask_of_mempolicy(nodes_allowed))) {
> > + NODEMASK_FREE(nodes_allowed);
> > + nodes_allowed = &node_states[N_HIGH_MEMORY];
> > + }
> > + h->max_huge_pages = set_max_huge_pages(h, count, &node_online_map);
> >
>
> Should that node_online_map not have changed to nodes_allowed?
>
Looks like that's done in patch 6/10 of the series, but I agree it's more
applicable here for review purposes.
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
