On Tue, 2009-04-28 at 14:38 -0500, Cliff Wickman wrote: > Hi Lee, > > On Tue, Apr 28, 2009 at 12:36:21PM -0400, Lee Schermerhorn wrote: > > This is a series of patches to the numactl/libnuma package, against > > numactl-2.0.3-rc2. A couple of these patches include hunks that may > > be or are already in the Cliff's tree--see the patch descriptions. > > I've included them here as these are what I've tested with. > > > > + libnuma: > > ++ fix apparent bitmask memory leaks; > > ++ always return freeable bitmask pointers, instead of pointers to > > libnuma exported masks such as numa_no_nodes_ptr > > ++ fix parsing of /proc/self/status cpu and node masks in > > set_thread_constraints. > > > > + numademo: > > ++ add extra loop in memtest() to eliminate page allocation overhead > > from bandwidth stats. > > > > + Makefile: > > ++ define LIBNUMA_SO and use throughout the Makefile to support > > multiple versions on a system. > > > > + test/checkaffinity: > > ++ fix test expression to work if numactl should fail. > > > > > > Pick and choose as you see fit, Cliff. > > Thanks for all the clean-up. > > I have applied your patches and tested on ia64 (8 nodes). Good. I had tested on a 4-node x86_64 on a RHEL5 and a recent mmotm kernel. The latter is where I found the kernel breakage. > patch1: (but not the hunks that Kornilios had supplied) > patch2: bitmask memory leaks numa_tonode_memory() > numa_get_interleave_mask_v1() numa_run_on_node_mask_v2() > patch3: leaks in numa_get_membind_v1() numa_get_run_node_mask_v1() > numa_get_run_node_mask_v1() numa_get_run_node_mask_v2 numa_run_on_node() > patch4: return freeable bitmasks > patch5: parsing of /proc/self (extends Brice's) > patch6: numademo memtest page allocation overhead > patch8: test/checkaffinity script > > I did not apply patch 7. I think you and Andi agreed on that. Right. Andi showed me the light :). > > > The tarball is > ftp://oss.sgi.com/www/projects/libnuma/download/numactl-2.0.3-rc3.tar.gz > Thanks, Lee -- To unsubscribe from this list: send the line "unsubscribe linux-numa" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
