[PATCH] kernel testcase numa of LTP and use compatibility interface of libnuma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

the LTP numa testcases were initially designed for libnuma API in version 1.
Building latest LTP (intermediate 20080820) against latest version of libnuma
(2.0.2) requires -DNUMA_VERSION1_COMPATIBILITY in the CFLAGS - to switch to
to the compatibility interface of libnuma API version 1. There are no libnuma
testcases for API version 2 in ltp yet.

Currently -DNUMA_VERSION1_COMPATIBILITY will not help for the LTP numa testcase,
since the compability interface is missing some interface from version 1:

make[3]: Entering directory `/home/dgollub/packages/ltp/ltp-intermediate-20080820/testcases/kernel/numa'
cc -Wall  -I../../../include -Wall -DNUMA_VERSION1_COMPATIBILITY    numa_node_size.c  -L../../../lib -lltp  -L../../../lib  -lnuma -o numa_node_size
numa_node_size.c: In function ‘main’:
numa_node_size.c:72: warning: passing argument 1 of ‘nodemask_zero’ from incompatible pointer type
numa_node_size.c:73: warning: implicit declaration of function ‘nodemask_set’
/tmp/cc2yij9O.o: In function `main':
numa_node_size.c:(.text+0x14f): undefined reference to `nodemask_set'
collect2: ld returned 1 exit status
make[3]: *** [numa_node_size] Error 1

Fix for the VERSION1 compatibility interface got already send to linux-numa list.
I hope the libnuma fix got accepted and attached can be applied to LTP soon to fix
the build of the LTP numa testcases, when building against libnuma 2.0.2 or greater.

Signed-off-by: Daniel Gollub <dgollub@xxxxxxx>

---
diff --git a/testcases/kernel/numa/Makefile b/testcases/kernel/numa/Makefile
index a522938..a903d63 100644
--- a/testcases/kernel/numa/Makefile
+++ b/testcases/kernel/numa/Makefile
@@ -16,7 +16,7 @@
 #  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 #
 
-CFLAGS += -I../../../include -Wall 
+CFLAGS += -I../../../include -Wall -DNUMA_VERSION1_COMPATIBILITY
 
 LDLIBS += -L../../../lib -lltp 
 
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [Devices]

  Powered by Linux