Hi Mr. Yamato, On Fri, Jul 18, 2008 at 03:57:58PM +0900, Masatake YAMATO wrote: > Hi, > > I posted following message to linux-numa@xxxxxxxxxxxxxxxx > However, as far as reading the archive of linux-numa@xxxxxxxxxxxxxxx, > the list is not active. So I've decided to send this to directly to > the maintainers. Sorry for the lag. I've been distracted. I agree. In fact there is also redundancy with the system calls defined in both numaif.h and numaint.h So I fixed the one you pointed out in numaif.h, and removed them entirely from numaint.h There are a couple other issues outstanding. Then I'll post it ftp://oss.sgi.com/www/projects/libnuma/download/ as numactl-2.0.2-rc3 Thanks. -Cliff > > ------------------------------------------------------------- > As far as reading libnuma code, declaration of > migratepages in numaif.h is meaningless; none code > in the library uses it and no implementation for > the declaration in the library. > > After thinking I guess following patch may be needed > If my guessing is correct, please apply the patch to your > master tree. > > Signed-off-by: Masatake YAMATO<yamato@xxxxxxxxxx> > > --- numaif.h.orig 2008-07-17 17:16:33.000000000 +0900 > +++ numaif.h 2008-07-17 17:20:33.000000000 +0900 > @@ -14,8 +14,8 @@ > const unsigned long *nmask, unsigned long maxnode, unsigned flags); > extern long set_mempolicy(int mode, const unsigned long *nmask, > unsigned long maxnode); > -extern long migratepages(int pid, unsigned long maxnode, unsigned long *fromnode, > - unsigned long *tonode); > +extern long migrate_pages(int pid, unsigned long maxnode, const unsigned long *fromnode, > + const unsigned long *tonode); > > extern long move_pages(int pid, unsigned long count, > void **pages, const int *nodes, int *status, int flags); > [yamato@beach numactl-2.0.2-rc2]$ > ------------------------------------------------------------- -- Cliff Wickman Silicon Graphics, Inc. cpw@xxxxxxx (651) 683-3824 -- To unsubscribe from this list: send the line "unsubscribe linux-numa" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
