Re: [RFC] numactl doesn't work as expected with --phycpubind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Index: numactl-0.9.8/Makefile
> ===================================================================
> --- numactl-0.9.8.orig/Makefile	2008-04-22 14:46:54.000000000 +0530
> +++ numactl-0.9.8/Makefile	2008-04-22 14:47:22.000000000 +0530
> @@ -1,6 +1,6 @@
>  # these can (and should) be overridden on the make command line for production
>  # use
> -CFLAGS :=  -g -Wall -O0
> +CFLAGS :=  -g -Wall -O0 -D_GNU_SOURCE

Please put the _GNU_SOURCE define into the source file. Users should be able to easily
override CFLAGS without needing to remember to set such magic flags. In fact
most rpm .specs are expected to override it to -O2 and would break.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [Devices]

  Powered by Linux