Re: libnuma debian patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ian,

On Mon, Jun 09, 2008 at 12:11:33PM -0700, Ian Wienand wrote:
> Great, I should get a chance to update the Debian package soon
> 
> If you've got time, could you take a look at
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485398
> 
> Seems a regression from the old version

   $ numactl -C 2,3 bash
 
   on a system with 4 cores I get

   libnuma: Warning: Cannot parse /proc/self/status
   numactl: cpu argument 2,3 is out of range
> 
> Cheers,
> 
> -i

Yes.  Thanks for finding that.  Seems some more lines have been
added to /proc/self/status at that kernel level.  libnuma.c has to be
patched a little to identify the line it needs to parse:

@@ -477,12 +478,12 @@ set_thread_constraints(void)
 
        while (fgets(buffer, buflen, f)) {
 
-               if (strncmp(buffer,"Cpus_allowed",12) == 0)
-                       maxproccpu = read_mask(buffer + 14, numa_all_cpus_ptr);
+               if (strncmp(buffer,"Cpus_allowed:",13) == 0)
+                       maxproccpu = read_mask(buffer + 15, numa_all_cpus_ptr);
 
-               if (strncmp(buffer,"Mems_allowed",12) == 0) {
+               if (strncmp(buffer,"Mems_allowed:",13) == 0) {
                        maxprocnode =
-                               read_mask(buffer + 14, numa_all_nodes_ptr);
+                               read_mask(buffer + 15, numa_all_nodes_ptr);
                }
        }
        fclose(f);

I added this patch to 2.0.1 as well.
And tested it on 2.6.16 and 2.6.26-rc2 kernels.

-Cliff
--
To unsubscribe from this list: send the line "unsubscribe linux-numa" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [Devices]

  Powered by Linux