> On Feb 29, 2024, at 19:45, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx> wrote: > > All of the fixes in this patch seem to be correct, but this doesn't > cover nilfs_resize_fs(), nilfs_max_segment_count(), and > nilfs_sb2_bad_offset(), which also have do_div() that doesn't use the > return value. I just tested this, and Coccinelle didn't report nilfs_resize_fs() or nilfs_max_segment_count() because both divisors are fields of a struct. I will refactor this and submit a v2. For nilfs_sb2_bad_offset(), where the dividend is u64 and the divisor is u32, we would need a dedicated function like div64_u32() that doesn't calculate the remainder, which doesn't seem to exist. What do you think? Thanks, Thorsten
