On Tue, Feb 20, 2024 at 5:44 PM Roman Smirnov wrote: > > On Thu, 8 Feb 2024 17:42:41 +0300, Roman Smirnov wrote: > > Syzkaller reports WARNING in nilfs_dat_prepare_end() in 5.10, 5.15 and 6.1 > > stable releases. The problem has been fixed in upstream: > > https://syzkaller.appspot.com/bug?extid=5d5d25f90f195a3cfcb4 > > > > The problem can also be fixed in versions 5.10, 5.15 and 6.1 by the > > following patch. > > > > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > > > Link: https://syzkaller.appspot.com/bug?extid=325e6b0a1e7cf9035cc0 > > Link: https://syzkaller.appspot.com/bug?extid=bebf30d67ea2569f0fd3 > > > > Ryusuke Konishi (1): > > nilfs2: replace WARN_ONs for invalid DAT metadata block requests > > > > fs/nilfs2/dat.c | 27 +++++++++++++++++---------- > > 1 file changed, 17 insertions(+), 10 deletions(-) > > Sorry to bother you, do you have any comments on the patch? Hi Greg, As a side note, this commit handles certain metadata corruptions better if they are detected, rather than just killing WARN_ONs, and prevents an internal error code (ENOENT) from propagating inappropriately to userland. So, in retrospect, I think it was worth backporting to stable trees. I have checked the source code of each of the target stable trees, and they are safe to apply. Thanks, Ryusuke Konishi
