Re: [PATCH] nilfs2: Add missing set_freezable() for freezable kthread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 17, 2023 at 10:50 PM Kevin Hao wrote:
>
> The kernel thread function nilfs_segctor_thread() invokes
> the try_to_freeze() in its loop. But all the kernel threads are
> non-freezable by default. So if we want to make a kernel thread to be
> freezable, we have to invoke set_freezable() explicitly.
>
> Signed-off-by: Kevin Hao <haokexin@xxxxxxxxx>
> ---
>  fs/nilfs2/segment.c | 1 +
>  1 file changed, 1 insertion(+)

Thank you!
I'll grab this and send it upstream.

Ryusuke Konishi

>
> diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c
> index 52995838f2de..2590a0860eab 100644
> --- a/fs/nilfs2/segment.c
> +++ b/fs/nilfs2/segment.c
> @@ -2588,6 +2588,7 @@ static int nilfs_segctor_thread(void *arg)
>                    "segctord starting. Construction interval = %lu seconds, CP frequency < %lu seconds",
>                    sci->sc_interval / HZ, sci->sc_mjcp_freq / HZ);
>
> +       set_freezable();
>         spin_lock(&sci->sc_state_lock);
>   loop:
>         for (;;) {
> --
> 2.39.2
>





[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux