On Mon, Nov 27, 2023 at 11:30:20PM +0900, Ryusuke Konishi wrote: > In a few directory operations, the call to nilfs_put_page() for a page > obtained using nilfs_find_entry() or nilfs_dotdot() is hidden in > nilfs_set_link() and nilfs_delete_entry(), making it difficult to track > page release and preventing change of its call position. > > By moving nilfs_put_page() out of these functions, this makes the page > get/put correspondence clearer and makes it easier to swap > nilfs_put_page() calls (and kunmap calls within them) when modifying > multiple directory entries simultaneously in nilfs_rename(). > > Also, update comments for nilfs_set_link() and nilfs_delete_entry() to > reflect changes in their behavior. > > To make nilfs_put_page() visible from namei.c, this moves its definition > to nilfs.h and replaces existing equivalents to use it, but the exposure > of that definition is temporary and will be removed on a later > kmap -> kmap_local conversion. > > Signed-off-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx> > Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Ah; I see. This makes it more like ext2, so I approve! Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
