On Tue, Jun 06, 2023 at 09:39:35AM +0200, Christoph Hellwig wrote: > The current interface for exclusive opens is rather confusing as it > requires both the FMODE_EXCL flag and a holder. Remove the need to pass > FMODE_EXCL and just key off the exclusive open off a non-NULL holder. > > For blkdev_put this requires adding the holder argument, which provides > better debug checking that only the holder actually releases the hold, > but at the same time allows removing the now superfluous mode argument. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > block/bdev.c | 37 ++++++++++++++++------------ > block/fops.c | 6 +++-- > block/genhd.c | 5 ++-- > block/ioctl.c | 5 ++-- > drivers/block/drbd/drbd_nl.c | 23 ++++++++++------- > drivers/block/pktcdvd.c | 13 +++++----- > drivers/block/rnbd/rnbd-srv.c | 4 +-- > drivers/block/xen-blkback/xenbus.c | 2 +- > drivers/block/zram/zram_drv.c | 8 +++--- > drivers/md/bcache/super.c | 15 ++++++------ > drivers/md/dm.c | 6 ++--- > drivers/md/md.c | 38 +++++++++++++++-------------- > drivers/mtd/devices/block2mtd.c | 4 +-- > drivers/nvme/target/io-cmd-bdev.c | 2 +- > drivers/s390/block/dasd_genhd.c | 2 +- > drivers/target/target_core_iblock.c | 6 ++--- > drivers/target/target_core_pscsi.c | 8 +++--- For > fs/btrfs/dev-replace.c | 6 ++--- > fs/btrfs/ioctl.c | 12 ++++----- > fs/btrfs/volumes.c | 28 ++++++++++----------- > fs/btrfs/volumes.h | 6 ++--- Acked-by: David Sterba <dsterba@xxxxxxxx>