Re: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool
From: Christian Brauner <brauner@xxxxxxxxxx>
Date: Wed, 7 Jun 2023 10:59:48 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Chris Mason <clm@xxxxxx>, David Sterba <dsterba@xxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, dm-devel@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx
In-reply-to: <20230606073950.225178-23-hch@lst.de>
References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-23-hch@lst.de>

On Tue, Jun 06, 2023 at 09:39:41AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---

Looks good to me,
Acked-by: Christian Brauner <brauner@xxxxxxxxxx>

References:
- decouple block open flags from fmode_t
  - From: Christoph Hellwig
- [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool
Next by Date: Re: [PATCH 23/31] mtd: block: use a simple bool to track open for write
Previous by thread: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool
Next by thread: Re: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystem Development] [Linux BTRFS] [Linux CIFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux SCSI]