On Fri, Oct 28, 2022 at 12:09 AM Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx> > > Before a timer is freed, del_timer_shutdown() must be called. > > Link: https://lore.kernel.org/all/20220407161745.7d6754b3@xxxxxxxxxxxxxxxxxx/ > > Cc: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx> > Cc: linux-nilfs@xxxxxxxxxxxxxxx > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> > --- > fs/nilfs2/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c > index b4cebad21b48..1d3f89de1cd2 100644 > --- a/fs/nilfs2/segment.c > +++ b/fs/nilfs2/segment.c > @@ -2752,7 +2752,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci) > > down_write(&nilfs->ns_segctor_sem); > > - del_timer_sync(&sci->sc_timer); > + del_timer_shutdown(&sci->sc_timer); > kfree(sci); > } > > -- > 2.35.1 del_timer_shutdown() is not yet in the mainline, so I reply with: Acked-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx> in the sense that I agree with the purpose of introducing the new function and the place to apply it is correct in nilfs2. Thanks, Ryusuke Konishi
