From: cgel.zte@xxxxxxxxx > Sent: 19 August 2022 09:17 > > The brelse() function tests whether its argument is NULL > and then returns immediately. > Thus remove the tests which are not needed around the shown calls. The test is the caller makes sense if it is a 'hot' path and bh is normally NULL. David > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx> > Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx> > --- > fs/nilfs2/btree.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c > index f544c22fff78..b3b5a46488c2 100644 > --- a/fs/nilfs2/btree.c > +++ b/fs/nilfs2/btree.c > @@ -1668,8 +1668,7 @@ static int nilfs_btree_check_delete(struct nilfs_bmap *btree, __u64 key) > maxkey = nilfs_btree_node_get_key(node, nchildren - 1); > nextmaxkey = (nchildren > 1) ? > nilfs_btree_node_get_key(node, nchildren - 2) : 0; > - if (bh != NULL) > - brelse(bh); > + brelse(bh); > > return (maxkey == key) && (nextmaxkey < NILFS_BMAP_LARGE_LOW); > } > @@ -1717,8 +1716,7 @@ static int nilfs_btree_gather_data(struct nilfs_bmap *btree, > ptrs[i] = le64_to_cpu(dptrs[i]); > } > > - if (bh != NULL) > - brelse(bh); > + brelse(bh); > > return nitems; > } > -- > 2.25.1 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
