On Sun, Dec 12, 2021 at 3:09 AM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> Pointer sbufs is being assigned a value but it's not being used
> later on. The pointer is redundant and can be removed. Cleans up
> scan-build static analysis warning:
>
> fs/nilfs2/page.c:203:8: warning: Although the value stored to 'sbufs'
> is used in the enclosing expression, the value is never actually read
> from 'sbufs' [deadcode.DeadStores]
> sbh = sbufs = page_buffers(src);
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
Looks good.
Will apply, thank you.
Ryusuke Konishi
> ---
> fs/nilfs2/page.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index bc3e2cd4117f..063dd16d75b5 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -195,12 +195,12 @@ void nilfs_page_bug(struct page *page)
> */
> static void nilfs_copy_page(struct page *dst, struct page *src, int copy_dirty)
> {
> - struct buffer_head *dbh, *dbufs, *sbh, *sbufs;
> + struct buffer_head *dbh, *dbufs, *sbh;
> unsigned long mask = NILFS_BUFFER_INHERENT_BITS;
>
> BUG_ON(PageWriteback(dst));
>
> - sbh = sbufs = page_buffers(src);
> + sbh = page_buffers(src);
> if (!page_has_buffers(dst))
> create_empty_buffers(dst, sbh->b_size, 0);
>
> --
> 2.33.1
>
