Re: [PATCH] nilfs2: fix data loss with mmap()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 Sep 2014 00:24:05 +0200, Andreas Rohner wrote:
> On 2014-09-16 00:01, Ryusuke Konishi wrote:
>> Hi Andreas,
>> On Mon, 15 Sep 2014 21:47:30 +0200, Andreas Rohner wrote:
>>> This bug leads to reproducible silent data loss, despite the use of
>>> msync(), sync() and a clean unmount of the file system. It is easily
>>> reproducible with the following script:
> <snip>
>> Thank you for reporting this issue.
> 
> I just stumbled upon the weird behaviour of mmap() while testing the
> nilfs_sync_fs() patch.
> 
>> I'd like to look into this patch, it looks to point out an important
>> regression, but it may take some time since I am quite busy this week..
> 
> Of course. I understand.

The patch looks correct.  It is my mistake that the commit 136e877
leaked consideration for the case where the page doesn't have buffer
heads.  This fix should be backported to stable kernels. (I'll add a
"Cc: stable" tag when sending this to Andrew.)

Did you confirm that the patch works as expected ?

I'd appreciate your help on testing the patch for some old kernels.
(And, please declare a "Tested-by" tag in the reply mail, if the test
is ok).

Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux