Re: [PATCH v2 2/5] nilfs-utils: cleanerd: add custom error value to enable fast retry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 21, 2014, at 4:59 PM, Andreas Rohner wrote:

> This patch adds the custom error value EGCTRYAGAIN, which signals to
> cleanerd to retry the GC process as soon as possible with no timeout.
> 
> If the GC decides not to do any real work and only changes a few
> metadata bytes, there is no need for a timeout. Furthermore if the GC is
> running, there is probably not enough free space on the device and it is
> crucial to retry quickly.
> 

What does it defend us from eating 100% of CPU?

> Signed-off-by: Andreas Rohner <andreas.rohner@xxxxxxx>
> ---
> include/nilfs_gc.h       |  2 ++
> sbin/cleanerd/cleanerd.c | 10 +++++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/include/nilfs_gc.h b/include/nilfs_gc.h
> index 72e9947..7628ce1 100644
> --- a/include/nilfs_gc.h
> +++ b/include/nilfs_gc.h
> @@ -27,4 +27,6 @@ static inline int nilfs_suinfo_reclaimable(const struct nilfs_suinfo *si)
> 
> extern void (*nilfs_gc_logger)(int priority, const char *fmt, ...);
> 
> +#define EGCTRYAGAIN 513

Why do you declare a new constant? What does it means value of 513?
What bad in EAGAIN?

Thanks,
Vyacheslav Dubeyko.

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux