On Sun, 2014-01-19 at 15:01 +0100, Andreas Rohner wrote: It is expected "From: <author name and name>" and "Subject: <subject>" in the begin of patch. > With this option the user can specify the minimal number of free/dead > blocks, which is a threshold for the GC. If there are less free blocks > to gain from cleaning a segment than the specified number, the GC will > abort and try again with a different segment. > What will be under stress? I mean situation when we processed all segments that it is valuable for cleaning on threshold basis. Then we need to clean segments for space allocation but all "dirty" segments not reasonable choice for cleaning because of threshold. What will we have in situation when an user selects not proper value of threshold? I worried about situation of skipping sibling segments from cleaning. Is NILFS2 driver really ready for this? Did you think about efficiency of free space allocation after such cleaning and about file system consistency? Are you sure that all will be good after such approach of cleaning? I simply want to be sure that you have analyzed this. Thanks, Vyacheslav Dubeyko. -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html