Re: [PATCH] nilfs2: correct logic of translation virtual blocks number into physical ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ryusuke,

On Tue, 2013-07-02 at 01:02 +0900, Ryusuke Konishi wrote:

[snip]
> Vyacheslav, this patch breaks snapshot mounts because past blocks
> deleted from the current file system have an end checkpoint number
> smaller than the current checkpoint number.
> 

Yes, you are right. It needs to rework this patch.

I will be on vacation during next two weeks. And then, after vacation, I
continue to work with patches and fixes for NILFS2. I will keep silence
during my vacation time.

Thank you for the remark.

> Also, the title of this patch looks wrong.  You are trying to insert a
> sanity check in the translation logic.  It doesn't correct translation
> logic itself, nor removes the cause of reported problem.
> 
> I think the title of this patch should be "nilfs2: insert sanity check
> in translation logic of ..."  or so.

Ok. I agree.

With the best regards,
Vyacheslav Dubeyko.

> 
> Regards,
> Ryusuke Konishi
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux