Hi! Am Samstag, 23. März 2013 schrieb Ryusuke Konishi: > On Sat, 23 Mar 2013 15:45:22 +0400, Vyacheslav Dubeyko wrote: > > From: Vyacheslav Dubeyko <slava@xxxxxxxxxxx> > > Subject: [PATCH] nilfs-utils: mkfs.nilfs2 should check presence of > > NILFS2 volume on device > > > > The mkfs.nilfs2 utility should check presence of NILFS2 volume on > > device and to warn a user about possibility to destroy data by mkfs > > activity. This patch tries to read and to validate checksums of > > primary and secondary superblocks on opened device. If this operation > > ends successfully then mkfs.nilfs2 informs a user about potential > > danger to destroy existing NILFS2 volume. The execution of mkfs.nilfs2 > > stops with offering to make decision about continuation or abortion of > > operation. However, if a user runs mkfs.nilfs2 with "-q" option then > > checking of NILFS2 volume is skipped. > > > > Reported-by: Hendrik Levsen <hendrik@xxxxxxxxxx> > > Signed-off-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx> > > Tested-by: Vyacheslav Dubeyko <slava@xxxxxxxxxxx> > > This patch breaks compatibility of mkfs.nilfs2 in the case when users > or tools are expecting overwrite an exisiting partition. However, I > am inclined to accept this kind of protection feature. > > One thing disturbing is that "quiet option" is used to turn off the > protection; "quiet option" is just an option to suppress messages. > > Please consider adding "force overwrite (-f)" option like > mkfs.xfs. Also please consider adding of other filesystems via blkid just as mkfs.xfs and since a short time also mkfs.btrfs does. I agree on "-f" being a suitable option for force formatting the volume. Thanks, -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
