Hi, On Fri, 23 Dec 2011 01:35:41 +0900 (JST), Ryusuke Konishi wrote: > Hi, > On Wed, 21 Dec 2011 15:34:02 -0600, Dan McGee wrote: > > This is a short series of patches with some improvements and code cleanups. > > Most should be rather independent of each other and I'm definitely open to any > > feedback. > > Thank you for posting this series. > I will review them each later. > > Regards, > Ryusuke Konishi Most of the patches looks fine to me. A nice cleanup series, thank you. My only objection is for a change in error handling of the patch 7/7. I already added the comment on the patch, please consider revising it. Then, I will apply them all toward nilfs-utils-2.1.1 release. Thank you, Ryusuke Konishi > > Dan McGee (7): > > Add .gitignore rules for generated binaries > > umount.nilfs2 (libmount): send proper error code to complain function > > Remove kern_compat.h > > Alpha sort AC_CHECK_FUNCS list in configure.ac > > Use strtoull instead of strtoul where applicable > > rmcp/chcp: sanity check for positive checkpoint number > > rmcp: print sensible error message on permission failure > > > > bin/.gitignore | 6 +++++ > > bin/Makefile.am | 2 +- > > bin/chcp.c | 7 +++-- > > bin/dumpseg.c | 4 +- > > bin/rmcp.c | 10 +++++--- > > configure.ac | 8 +++--- > > include/Makefile.am | 2 +- > > include/cno.h | 1 + > > include/kern_compat.h | 47 ---------------------------------------- > > lib/cno.c | 29 +++++++++++++++++------ > > lib/feature.c | 2 +- > > sbin/cleanerd/.gitignore | 1 + > > sbin/mkfs/.gitignore | 1 + > > sbin/mkfs/mkfs.c | 3 +- > > sbin/mkfs/mkfs.h | 4 --- > > sbin/mount/.gitignore | 2 + > > sbin/mount/umount_libmount.c | 4 +-- > > sbin/nilfs-clean/.gitignore | 1 + > > sbin/nilfs-clean/nilfs-clean.c | 2 +- > > sbin/nilfs-resize/.gitignore | 1 + > > sbin/nilfs-tune/.gitignore | 1 + > > 21 files changed, 58 insertions(+), 80 deletions(-) > > create mode 100644 bin/.gitignore > > delete mode 100644 include/kern_compat.h > > create mode 100644 sbin/cleanerd/.gitignore > > create mode 100644 sbin/mkfs/.gitignore > > create mode 100644 sbin/mount/.gitignore > > create mode 100644 sbin/nilfs-clean/.gitignore > > create mode 100644 sbin/nilfs-resize/.gitignore > > create mode 100644 sbin/nilfs-tune/.gitignore > > > > -- > > 1.7.8 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
