Re: nilfs_cleanerd not started for mount with relative pathname

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
On Fri, 04 Mar 2011 02:32:04 +0900 (JST), Ryusuke Konishi wrote:
> On Wed, 2 Mar 2011 18:12:31 +0100, dexen deVries wrote:
> > Hi,
> > 
> > 
> > when testing my other patches, the following came up:
> > 
> > with absolute pathname:
> > # mount /dev/sdb2 /mnt/x
> > # ps ax | grep [n]ilfs_cleanerd
> > 30408 ?        Ss     0:00 /sbin/nilfs_cleanerd -n /dev/sdb2 /mnt/x
> > 
> > 
> > with relative mountpoint pathname:
> > # umount /mnt/x
> > # cd /mnt
> > # mount /dev/sdb2 x
> > # ps ax | grep [n]ilfs_cleanerd
> > ((no such process))
> > 
> > with relative device pathname:
> > # umount /mnt/x
> > # cd /dev
> > # mount sdb2 /mnt/x
> > # ps ax | grep [n]ilfs_cleanerd
> > ((no such process))
> > 
> > This is due to chdir(ROOTDIR) in daemonize(); currently daemonize is always 
> > called with nochdir == 0. Should I hardcode it to nochdir == 1 or canonicalize 
> > the `dev' and `dir' arguments with myrealpath()?
> 
> It sounds like cleanerd needs a fix.
> I'll take a look and answer to you tomorrow.
> 
> Thanks,
> Ryusuke Konishi

This was actually a cleanerd bug. (Good catch)

Cleanerd should canonicalize the dev and dir arguments before calling
the daemonize function as you pointed out.

Would you like to have a go at this ?

Thanks,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux