Ryusuke Konishi wrote: > On Fri, 21 Jan 2011 16:37:38 +0900 (JST), Ryusuke Konishi wrote: > > (Cc'ed to linux-nilfs) > > > [ 1202.581501] NILFS warning: broken superblock. using spare superblock. > > > [ 1202.582093] NILFS warning: broken superblock. using spare superblock. Why does it say this 2 times? Just curious. > > Thanks for the report. > > > > This seems to be a regression on 2.6.36 which could happen when one of > > two superblocks is broken. > > > > I'll fix it. > > Does the following patch fix your problem? > diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c > index 0994f6a7..58fd707 100644 > --- a/fs/nilfs2/super.c > +++ b/fs/nilfs2/super.c > @@ -704,7 +704,8 @@ skip_mount_setup: > sbp[0]->s_state = > cpu_to_le16(le16_to_cpu(sbp[0]->s_state) & ~NILFS_VALID_FS); > /* synchronize sbp[1] with sbp[0] */ > - memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); > + if (sbp[1]) > + memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); > return nilfs_commit_super(sbi, NILFS_SB_COMMIT_ALL); > } That patch fix it. Just a note, the 2.6.37 vanilla source was about 20 lines up from 704 -- Microsoft has beaten Volkswagen's world record. Volkswagen only created 22 million bugs. -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
