Re: [PATCH 0/1] replace crc32.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
On Fri, 19 Nov 2010 17:31:06 +0900, Jiro SEKIBA wrote:
> Hi,
> 
> I think we've had consensus that libnilfs2 should be LGPLed. 
> The problems are included GPLed kernel header(nilfs2_fs.h) and
> crc32.c derived from GPL2 base code.
>  http://www.mail-archive.com/linux-nilfs@xxxxxxxxxxxxxxx/msg00489.html
> 
> The kernel header is properly re-licensed as LGPL2.1 in 2.6.37 merge window.
> Thus the only problem is crc32.c now.
> 
> The following patch addresses the remaining problem.
> The patch replaces crc32.c implementation.
> The implementation is based on the jamlib(*1) and is LGPL2.1.
> *1) http://sourceforge.net/projects/jamlib/
> 
> I've checked the compatibility on x86, ppc32 and mixed environments.
> Everything was OK.
> 
> thanks, regards
> -- 
> Jiro SEKIBA <jir@xxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thank you!

The patch looks fine except for a typo.  The following patch will fix
the typo.

I will meld it into your patch and queue it up for the next util
release.

Thanks,
Ryusuke Konishi

diff --git a/lib/crc32.c b/lib/crc32.c
index 32a1a16..c75a361 100644
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -1,5 +1,5 @@
 /*
- * crc32 calclulation
+ * crc32 calculation
  *
  * Copyright (C) 2010 Jiro SEKIBA <jir@xxxxxxxxx>
  *
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux BTRFS]     [Linux CIFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux