On Tue, 24 Aug 2010 04:30:28 -0400, Christoph Hellwig wrote: > On Tue, Aug 24, 2010 at 05:48:44PM +1000, Nick Piggin wrote: > > The reason I broke nilfs2 is because it duplicates a lot of the > > generic inode initialisation code. This really should go in core > > code because nilfs2 does not own the generic inode fields. > > > > It just needs some helper function to do the non-sb related init > > stuff for you. > > No, the problem is much deeper than that. Having inodes outlive > superblock is fundamentally broken. All that crap simply needs > to go away. I agree.. I will try to resolve this problem, or will separate three metadata files outlive superblock if I cannot find a proper way. Actually, I recently wrote a patchset to unify all super block instances on one device into one sb, which makes the inodes outlive superblock eliminable. But the patchset has a problem that it cannot shrink a number of versions of namespace when unmounting all snapshots and a current time instance. If this implementation issue is avoidable, unifying per-snapshot sb instances seems an ideal way. Thanks, Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
